[MusicXML] Support for notehead names #737
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
force-pushed
the
3.x-xml/noteheads
branch
from
a0d2662 to
992a02c
Compare
Jojo-Schmitz
commented
Dec 25, 2024
| QRegExp nameparts("^note([A-Z][a-z]*)(Sharp|Flat)?"); | ||
| const char* noteheadName = Sym::id2name(note->noteHead()); | ||
| #if QT_VERSION >= QT_VERSION_CHECK(5, 11, 0) | ||
| QStringList matches = QString::fromLatin1(noteheadName).split(nameparts, Qt::SkipEmptyParts); |
There was a problem hiding this comment.
This is not right. Need to find an equivalent for the original PR's
StringList matches = String::fromAscii(noteheadName.ascii()).search(nameparts, { 1, 2 }, SplitBehavior::SkipEmptyParts);
Jojo-Schmitz
force-pushed
the
3.x-xml/noteheads
branch
from
992a02c to
d519eb5
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
9326c7c to
88927e8
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
20 times, most recently
from
e03471a to
a4d9423
Compare
Jojo-Schmitz
force-pushed
the
3.x
branch
2 times, most recently
from
80f2c72 to
19855f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of musescore#25916